Bug 45810 - [GStreamer] XOverlay API changes break the build
Summary: [GStreamer] XOverlay API changes break the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 01:13 PDT by Philippe Normand
Modified: 2010-09-16 08:32 PDT (History)
0 users

See Also:


Attachments
proposed patch (1.76 KB, patch)
2010-09-15 01:40 PDT, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-09-15 01:13:35 PDT
The upcoming gst-plugins-base 0.10.31 (currently git master) will break our build, see:

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=6dc02137fb8e952c79479f0c1154831c1b761410

We need some ifdefs :)
Comment 1 Philippe Normand 2010-09-15 01:40:27 PDT
Created attachment 67656 [details]
proposed patch
Comment 2 Martin Robinson 2010-09-16 08:21:57 PDT
Comment on attachment 67656 [details]
proposed patch

Great!
Comment 3 Philippe Normand 2010-09-16 08:32:32 PDT
Committed r67621: <http://trac.webkit.org/changeset/67621>