Bug 45536 - [Qt] MiniBrowser crashes with multiply windows when closing one of them
Summary: [Qt] MiniBrowser crashes with multiply windows when closing one of them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 06:00 PDT by Balazs Kelemen
Modified: 2010-09-10 18:57 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (2.38 KB, patch)
2010-09-10 06:28 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-09-10 06:00:35 PDT 
It seems to be that we had taken the wrong assumption that there are only one window with one page, therefore there are two ownership related problem that breaks MiniBrowser when there are multiply windows and the user closing one of them.
Comment 1 Balazs Kelemen 2010-09-10 06:28:04 PDT 
Created attachment 67175 [details]
proposed patch
Comment 2 Andreas Kling 2010-09-10 09:24:21 PDT 
Comment on attachment 67175 [details]
proposed patch

LGTM
Comment 3 WebKit Commit Bot 2010-09-10 18:57:14 PDT 
Comment on attachment 67175 [details]
proposed patch

Clearing flags on attachment: 67175

Committed r67266: <http://trac.webkit.org/changeset/67266>
Comment 4 WebKit Commit Bot 2010-09-10 18:57:19 PDT 
All reviewed patches have been landed.  Closing bug.