RESOLVED FIXED45502
JSObjectSetPrivateProperty does not handle NULL values as it claims 
https://bugs.webkit.org/show_bug.cgi?id=45502
Summary JSObjectSetPrivateProperty does not handle NULL values as it claims
Mark Rowe (bdash)
Reported 2010-09-09 16:18:31 PDT
The headerdoc for JSObjectSetPrivateProperty claims that passing NULL as the value is valid. In practice this leads to assertion failures with debug builds of JavaScriptCore.
Attachments
Patch (4.62 KB, patch)
2010-09-09 16:22 PDT, Mark Rowe (bdash) 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2010-09-09 16:22:57 PDT
Created attachment 67113 [details] Patch
Oliver Hunt
Comment 2 2010-09-09 16:24:55 PDT
Comment on attachment 67113 [details] Patch r=me
WebKit Review Bot
Comment 3 2010-09-09 18:12:35 PDT
http://trac.webkit.org/changeset/67129 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/67128 http://trac.webkit.org/changeset/67129 http://trac.webkit.org/changeset/67126 http://trac.webkit.org/changeset/67127
Eric Seidel (no email)
Comment 4 2010-10-13 12:27:18 PDT
Attachment 67113 [details] was posted by a committer and has review+, assigning to Mark Rowe for commit.
Mark Rowe (bdash)
Comment 5 2010-10-13 12:30:09 PDT
This was landed way back in r67129.
Note You need to log in before you can comment on or make changes to this bug.