Bug 45502 - JSObjectSetPrivateProperty does not handle NULL values as it claims
Summary: JSObjectSetPrivateProperty does not handle NULL values as it claims
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Major
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 16:18 PDT by Mark Rowe (bdash)
Modified: 2010-10-13 12:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.62 KB, patch)
2010-09-09 16:22 PDT, Mark Rowe (bdash) 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2010-09-09 16:18:31 PDT 
The headerdoc for JSObjectSetPrivateProperty claims that passing NULL as the value is valid.  In practice this leads to assertion failures with debug builds of JavaScriptCore.
Comment 1 Mark Rowe (bdash) 2010-09-09 16:22:57 PDT 
Created attachment 67113 [details]
Patch
Comment 2 Oliver Hunt 2010-09-09 16:24:55 PDT 
Comment on attachment 67113 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2010-09-09 18:12:35 PDT 
http://trac.webkit.org/changeset/67129 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67128
http://trac.webkit.org/changeset/67129
http://trac.webkit.org/changeset/67126
http://trac.webkit.org/changeset/67127
Comment 4 Eric Seidel (no email) 2010-10-13 12:27:18 PDT 
Attachment 67113 [details] was posted by a committer and has review+, assigning to Mark Rowe for commit.
Comment 5 Mark Rowe (bdash) 2010-10-13 12:30:09 PDT 
This was landed way back in r67129.