WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45413
fix show_results in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=45413
Summary
fix show_results in new-run-webkit-tests
Tony Chang
Reported
2010-09-08 14:10:51 PDT
fix show_results in new-run-webkit-tests
Attachments
Patch
(1.43 KB, patch)
2010-09-08 14:11 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch
(1.18 KB, patch)
2010-09-08 15:59 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2010-09-08 14:11:20 PDT
Created
attachment 66939
[details]
Patch
Tony Chang
Comment 2
2010-09-08 14:12:58 PDT
In
bug 45090
, an assert was added that ensures filename_to_uri is only called on layout test files. This broke a caller in show_results_html_file, so fix the caller to not use filename_to_uri.
Tony Chang
Comment 3
2010-09-08 14:13:29 PDT
I meant dpranke, not dglazkov.
Dirk Pranke
Comment 4
2010-09-08 14:54:19 PDT
Comment on
attachment 66939
[details]
Patch LGTM. I waffled on removing the assertion instead, but I think that this is probably better.
Eric Seidel (no email)
Comment 5
2010-09-08 15:51:14 PDT
Comment on
attachment 66939
[details]
Patch um, just make filename_to_uri add an extra /, no? It will be ignored on platforms which dont' care. // is the same as /
Tony Chang
Comment 6
2010-09-08 15:59:37 PDT
Created
attachment 66953
[details]
Patch
Tony Chang
Comment 7
2010-09-08 16:00:22 PDT
Comment on
attachment 66953
[details]
Patch Actually, let's not even bother with file:/// since we're just passing the filename on the command line.
WebKit Commit Bot
Comment 8
2010-09-09 01:30:51 PDT
Comment on
attachment 66953
[details]
Patch Clearing flags on attachment: 66953 Committed
r67069
: <
http://trac.webkit.org/changeset/67069
>
WebKit Commit Bot
Comment 9
2010-09-09 01:30:56 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug