Bug 45064 - Change ImmutableArray to be backed by a Vector
Summary: Change ImmutableArray to be backed by a Vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 15:02 PDT by Sam Weinig
Modified: 2010-09-01 16:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.50 KB, patch)
2010-09-01 15:08 PDT, Sam Weinig 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-09-01 15:02:30 PDT 
We need to change ImmutableArray to be backed by a Vector, so that we can add a MutableArray subclass.
Comment 1 Sam Weinig 2010-09-01 15:08:16 PDT 
Created attachment 66284 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-01 15:12:04 PDT 
Attachment 66284 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:130:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/Shared/ImmutableArray.h:58:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-09-01 16:03:03 PDT 
Fixed in http://trac.webkit.org/changeset/66621.