Bug 44973 - REGRESSION(r66519): Broke GTK+. (Requested by kov on #webkit).
Summary: REGRESSION(r66519): Broke GTK+. (Requested by kov on #webkit).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 12:43 PDT by WebKit Review Bot
Modified: 2010-08-31 13:53 PDT (History)
1 user (show)

See Also:


Attachments
ROLLOUT of r66519 (895.86 KB, patch)
2010-08-31 12:44 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-08-31 12:43:49 PDT
http://trac.webkit.org/changeset/66519 broke the build:
Broke GTK+. (Requested by kov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-31 12:44:06 PDT
Created attachment 66088 [details]
ROLLOUT of r66519

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Gustavo Noronha (kov) 2010-08-31 12:46:34 PDT
Comment on attachment 66088 [details]
ROLLOUT of r66519

Looks like the gettext on the bot doesn't like the po files generated by my gettext.
Comment 3 Gustavo Noronha (kov) 2010-08-31 12:54:35 PDT
Comment on attachment 66088 [details]
ROLLOUT of r66519

Clearing flags on attachment: 66088

Committed r66525: <http://trac.webkit.org/changeset/66525>
Comment 4 Gustavo Noronha (kov) 2010-08-31 12:54:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gustavo Noronha (kov) 2010-08-31 13:53:34 PDT
FWIW, it looks like the patch I rolled out was not the issue - svn had conflicts with the files, and skipped them.