Bug 44955 - Prepare RenderSVGContainer culling patch
Summary: Prepare RenderSVGContainer culling patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 44896
  Show dependency tree / graph
 
Reported: 2010-08-31 08:12 PDT by Nikolas Zimmermann
Modified: 2010-09-01 00:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.62 KB, patch)
2010-08-31 08:23 PDT, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-08-31 08:12:46 PDT 
Prepare RenderSVGContainer culling, bug 44896.
Comment 1 Nikolas Zimmermann 2010-08-31 08:23:38 PDT 
Created attachment 66057 [details]
Patch
Comment 2 Dirk Schulze 2010-08-31 23:04:39 PDT 
Comment on attachment 66057 [details]
Patch

Great that you split more parts out of the original patch. Just rephrase the first sentence in your Cahngelog. "Add styleWillChange methods ... if the style difference is StyleDifferenceLayout" The if sounds a bit strange here. And you should mention that the follow-up patch will cache the rects for container. Souds like a feature for the far future here :-)

r=me
Comment 3 Nikolas Zimmermann 2010-09-01 00:18:29 PDT 
Landed in r66584.