Bug 44550 - [CHROMIUM] Failing layout tests on Chromium/Linux
Summary: [CHROMIUM] Failing layout tests on Chromium/Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 14:11 PDT by Stephen White
Modified: 2010-08-24 14:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2010-08-24 14:24 PDT, Stephen White
dumi: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-08-24 14:11:46 PDT
LayoutTests/fast/canvas/arc-crash.html = CRASH
LayoutTests/fast/canvas/canvas-state-intact-after-putImageData.html = CRASH
LayoutTests/fast/canvas/toDataURL-supportedTypes.html = CRASH
Comment 1 Stephen White 2010-08-24 14:24:23 PDT
Created attachment 65324 [details]
Patch
Comment 2 James Robinson 2010-08-24 14:32:39 PDT
Fix looks correct and needed in general.  I'm pretty curious why we can't repro this locally.
Comment 3 Dumitru Daniliuc 2010-08-24 14:34:56 PDT
Comment on attachment 65324 [details]
Patch

rs=me.
Comment 4 Stephen White 2010-08-24 14:52:16 PDT
Committed r65938: <http://trac.webkit.org/changeset/65938>
Comment 5 Stephen White 2010-08-24 14:54:00 PDT
BTW, I did manage to repro, in the end, and confirmed that this fix ameliorates the crashes.  Just had to run all the tests, instead of just the failing ones.