Bug 44549 - crash when rendering scrollbar gradient
Summary: crash when rendering scrollbar gradient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 13:53 PDT by Tony Chang
Modified: 2010-08-26 14:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2010-08-24 13:55 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
test case (781 bytes, text/html)
2010-08-24 13:55 PDT, Tony Chang 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-08-24 13:53:17 PDT 
crash when rendering scrollbar gradient
Comment 1 Tony Chang 2010-08-24 13:55:17 PDT 
Created attachment 65316 [details]
Patch
Comment 2 Tony Chang 2010-08-24 13:55:56 PDT 
Created attachment 65317 [details]
test case
Comment 3 Tony Chang 2010-08-24 13:58:40 PDT 
Hyatt, can you review this?

The test case crashes Chrome and Safari Win.  It doesn't crash on Safari Mac, I think because on Safari Mac, the main scrollbars can't be styled.
Comment 4 Dave Hyatt 2010-08-26 11:11:59 PDT 
Comment on attachment 65316 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2010-08-26 12:39:24 PDT 
Comment on attachment 65316 [details]
Patch

Rejecting patch 65316 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
Core/ChangeLog
	M	WebCore/css/CSSImageGeneratorValue.cpp
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/LayoutTests/scrollbars/scrollbar-gradient-crash.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 572


Full output: http://queues.webkit.org/results/3732627
Comment 6 Tony Chang 2010-08-26 14:31:50 PDT 
http://trac.webkit.org/changeset/66133