Bug 43978 - [CMake] Set target properties only if available
Summary: [CMake] Set target properties only if available
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 43906
  Show dependency treegraph
Reported: 2010-08-13 08:55 PDT by Patrick R. Gansterer
Modified: 2010-08-14 08:18 PDT (History)
3 users (show)

See Also:

Patch (5.58 KB, patch)
2010-08-13 09:22 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-08-13 08:55:51 PDT
CMake throws an error if you call e.g. ADD_TARGET_PROPERTIES with an empty argument.
Comment 1 Patrick R. Gansterer 2010-08-13 09:22:30 PDT
Created attachment 64351 [details]
Comment 2 Leandro Pereira 2010-08-13 10:15:00 PDT
I'm not a reviewer, but the patch looks fine to me.
Comment 3 WebKit Commit Bot 2010-08-14 08:18:18 PDT
Comment on attachment 64351 [details]

Clearing flags on attachment: 64351

Committed r65366: <http://trac.webkit.org/changeset/65366>
Comment 4 WebKit Commit Bot 2010-08-14 08:18:23 PDT
All reviewed patches have been landed.  Closing bug.