Bug 43759 - Add zoom support for injected bundle
Summary: Add zoom support for injected bundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 16:59 PDT by Sam Weinig
Modified: 2010-08-09 18:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (16.87 KB, patch)
2010-08-09 17:03 PDT, Sam Weinig
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-08-09 16:59:36 PDT
Add zoom support for injected bundle. After that, we should also add API for the UIProcess API.
Comment 1 Sam Weinig 2010-08-09 17:03:03 PDT
Created attachment 63954 [details]
Patch
Comment 2 Geoffrey Garen 2010-08-09 18:34:27 PDT
Comment on attachment 63954 [details]
Patch

WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:40
 +          void zoomPageOut();
The inversion of noun and verb here is killing me! And like twelve kittens.

r=me
Comment 3 Geoffrey Garen 2010-08-09 18:34:58 PDT
(Inversion between "zoomPageOut" and "textZoomOut".)
Comment 4 Sam Weinig 2010-08-09 18:40:02 PDT
(In reply to comment #3)
> (Inversion between "zoomPageOut" and "textZoomOut".)

For everyone playing along at home, I can't change these since these are existing functions that tests use.
Comment 5 Sam Weinig 2010-08-09 18:43:25 PDT
Landed in r65029.