Bug 43637 - Add CoreIPC::MessageReceiver class
Summary: Add CoreIPC::MessageReceiver class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 13:08 PDT by Anders Carlsson
Modified: 2010-08-06 13:41 PDT (History)
0 users

See Also:


Attachments
Patch (7.50 KB, patch)
2010-08-06 13:14 PDT, Anders Carlsson
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-08-06 13:08:42 PDT
Add CoreIPC::MessageReceiver class
Comment 1 Anders Carlsson 2010-08-06 13:14:34 PDT
Created attachment 63753 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-08-06 13:17:36 PDT
Comment on attachment 63753 [details]
Patch

>  class Connection : public ThreadSafeShared<Connection> {
>  public:
> -    class Client {
> +    class MessageReceiver {
> +    public:
> +        virtual ~MessageReceiver() { }

It would be slightly for the destructor to be protected.

> +++ b/WebKit2/Shared/DrawingAreaBase.h
> @@ -27,18 +27,13 @@
>  #define DrawingAreaBase_h
>  
>  #include "ArgumentCoders.h"
> +#include "Connection.h"
>  
>  namespace WebCore {
>      class IntRect;
>      class IntSize;
>  }
>  
> -namespace CoreIPC {
> -    class ArgumentDecoder;
> -    class Connection;
> -    class MessageID;
> -}
> -

This change makes me a little sad.

r=me
Comment 3 Anders Carlsson 2010-08-06 13:41:39 PDT
Committed r64867: <http://trac.webkit.org/changeset/64867>