WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43637
Add CoreIPC::MessageReceiver class
https://bugs.webkit.org/show_bug.cgi?id=43637
Summary
Add CoreIPC::MessageReceiver class
Anders Carlsson
Reported
2010-08-06 13:08:42 PDT
Add CoreIPC::MessageReceiver class
Attachments
Patch
(7.50 KB, patch)
2010-08-06 13:14 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-08-06 13:14:34 PDT
Created
attachment 63753
[details]
Patch
Adam Roben (:aroben)
Comment 2
2010-08-06 13:17:36 PDT
Comment on
attachment 63753
[details]
Patch
> class Connection : public ThreadSafeShared<Connection> { > public: > - class Client { > + class MessageReceiver { > + public: > + virtual ~MessageReceiver() { }
It would be slightly for the destructor to be protected.
> +++ b/WebKit2/Shared/DrawingAreaBase.h > @@ -27,18 +27,13 @@ > #define DrawingAreaBase_h > > #include "ArgumentCoders.h" > +#include "Connection.h" > > namespace WebCore { > class IntRect; > class IntSize; > } > > -namespace CoreIPC { > - class ArgumentDecoder; > - class Connection; > - class MessageID; > -} > -
This change makes me a little sad. r=me
Anders Carlsson
Comment 3
2010-08-06 13:41:39 PDT
Committed
r64867
: <
http://trac.webkit.org/changeset/64867
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug