RESOLVED FIXED Bug 43518
[Qt][QtTestBrowser] Remove unneeded QAction class members 
https://bugs.webkit.org/show_bug.cgi?id=43518
Summary [Qt][QtTestBrowser] Remove unneeded QAction class members
Antonio Gomes
Reported 2010-08-04 16:15:52 PDT
LauncherWindow class has two totally unneeded class members: m_flopAnimated and m_flipYAnimated. Also, in initializeView method there are some dead code block trying to connect them at the wrong time, when they have not been instanciated.
Attachments
(committed with r64694, r=kenneth) patch (5.36 KB, patch)
2010-08-04 16:38 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-08-04 16:38:53 PDT
Created attachment 63511 [details] (committed with r64694, r=kenneth) patch This patch: - removes the two cited class members in favor of local variables in createChrome method; - removes the dead code block.
Antonio Gomes
Comment 2 2010-08-04 17:26:48 PDT
Comment on attachment 63511 [details] (committed with r64694, r=kenneth) patch Clearing flags on attachment: 63511 Committed r64694: <http://trac.webkit.org/changeset/64694>
Note You need to log in before you can comment on or make changes to this bug.