WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43393
Add VisitedLinkStrategy for each platform to implement
https://bugs.webkit.org/show_bug.cgi?id=43393
Summary
Add VisitedLinkStrategy for each platform to implement
Brady Eidson
Reported
Tuesday, August 3, 2010 1:14:16 AM UTC
Add VisitedLinkStrategy for each platform to implement
Attachments
Patch
(17.45 KB, patch)
2010-08-02 17:17 PDT
,
Brady Eidson
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
Tuesday, August 3, 2010 1:17:24 AM UTC
Created
attachment 63280
[details]
Patch
Brady Eidson
Comment 2
Tuesday, August 3, 2010 2:08:43 AM UTC
Committed
r64518
: <
http://trac.webkit.org/changeset/64518
>
Adam Barth
Comment 3
Tuesday, August 3, 2010 3:48:13 AM UTC
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(Build)/builds/14719/steps/compile-webkit/logs/stdio
** BUILD FAILED ** The following build commands failed: WebCore: CpHeader /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders/VisitedLinkStrategy.h platform/VisitedLinkStrategy.h CompileC /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HistoryController.o /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebCore/loader/HistoryController.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/CSSStyleSelector.o /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebCore/css/CSSStyleSelector.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (3 failures)
Brady Eidson
Comment 4
Tuesday, August 3, 2010 3:57:30 AM UTC
Forgot to svn add the header. Coming...
Brady Eidson
Comment 5
Tuesday, August 3, 2010 4:01:02 AM UTC
http://trac.webkit.org/changeset/64527
Adam Barth
Comment 6
Tuesday, August 3, 2010 4:06:19 AM UTC
thx
WebKit Review Bot
Comment 7
Tuesday, August 3, 2010 1:32:15 PM UTC
http://trac.webkit.org/changeset/64518
might have broken Leopard Intel Debug (Tests) The following changes are on the blame list:
http://trac.webkit.org/changeset/64517
http://trac.webkit.org/changeset/64518
http://trac.webkit.org/changeset/64519
http://trac.webkit.org/changeset/64520
http://trac.webkit.org/changeset/64521
http://trac.webkit.org/changeset/64522
http://trac.webkit.org/changeset/64523
http://trac.webkit.org/changeset/64524
http://trac.webkit.org/changeset/64525
http://trac.webkit.org/changeset/64526
http://trac.webkit.org/changeset/64527
Brady Eidson
Comment 8
Tuesday, August 3, 2010 5:13:51 PM UTC
Sorry for the test failures - I had other changes in my tree that masked them for me. I think Alexey fixed them in
http://trac.webkit.org/projects/webkit/changeset/64535
and I'll make sure that's a good permanent fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug