Bug 43393 - Add VisitedLinkStrategy for each platform to implement
Summary: Add VisitedLinkStrategy for each platform to implement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-02 17:14 PDT by Brady Eidson
Modified: 2010-08-03 09:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.45 KB, patch)
2010-08-02 17:17 PDT, Brady Eidson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-08-02 17:14:16 PDT
Add VisitedLinkStrategy for each platform to implement
Comment 1 Brady Eidson 2010-08-02 17:17:24 PDT
Created attachment 63280 [details]
Patch
Comment 2 Brady Eidson 2010-08-02 18:08:43 PDT
Committed r64518: <http://trac.webkit.org/changeset/64518>
Comment 3 Adam Barth 2010-08-02 19:48:13 PDT
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(Build)/builds/14719/steps/compile-webkit/logs/stdio

** BUILD FAILED **

The following build commands failed:
WebCore:
	CpHeader /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders/VisitedLinkStrategy.h platform/VisitedLinkStrategy.h
	CompileC /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HistoryController.o /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebCore/loader/HistoryController.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/CSSStyleSelector.o /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/WebCore/css/CSSStyleSelector.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(3 failures)
Comment 4 Brady Eidson 2010-08-02 19:57:30 PDT
Forgot to svn add the header.

Coming...
Comment 5 Brady Eidson 2010-08-02 20:01:02 PDT
http://trac.webkit.org/changeset/64527
Comment 6 Adam Barth 2010-08-02 20:06:19 PDT
thx
Comment 8 Brady Eidson 2010-08-03 09:13:51 PDT
Sorry for the test failures - I had other changes in my tree that masked them for me.

I think Alexey fixed them in http://trac.webkit.org/projects/webkit/changeset/64535 and I'll make sure that's a good permanent fix.