Bug 43333 - Buildbot for DRT/Chromium: "archived test results" step doesn't work
Summary: Buildbot for DRT/Chromium: "archived test results" step doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-02 03:19 PDT by Kent Tamura
Modified: 2010-08-04 22:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2010-08-03 23:31 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-08-02 03:19:50 PDT
The resultant zip file contains only .placeholder because
 - NRWT/Chromium command-line has "--results-directory layout-tests-results"
 - NRWT/Chromium assumes it as a relative path from webkit/<Configuration>/
 - WebKitTools/BuildSlaveSupport/test-results-archive script zips ./layout-tests-results

I have no idea how we should fix this at this moment.
Comment 1 Kent Tamura 2010-08-03 23:31:28 PDT
Created attachment 63419 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-08-04 07:51:46 PDT
Comment on attachment 63419 [details]
Patch

ok.
Comment 3 Dirk Pranke 2010-08-04 12:55:23 PDT
Nice. LGTM as well ... thanks for tracking this down.
Comment 4 Kent Tamura 2010-08-04 22:19:29 PDT
Comment on attachment 63419 [details]
Patch

Clearing flags on attachment: 63419

Committed r64709: <http://trac.webkit.org/changeset/64709>
Comment 5 Kent Tamura 2010-08-04 22:19:37 PDT
All reviewed patches have been landed.  Closing bug.