Bug 43160 - Implement NPN_InvokeDefault and NPN_Construct
Summary: Implement NPN_InvokeDefault and NPN_Construct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 17:00 PDT by Anders Carlsson
Modified: 2010-07-28 17:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.39 KB, patch)
2010-07-28 17:04 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-28 17:00:30 PDT 
Implement NPN_InvokeDefault and NPN_Construct
Comment 1 Anders Carlsson 2010-07-28 17:04:22 PDT 
Created attachment 62894 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-28 17:06:35 PDT 
Attachment 62894 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:551:  NPN_InvokeDefault is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:635:  NPN_Construct is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:270:  NPJSObject::NP_InvokeDefault is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:291:  NPJSObject::NP_Construct is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:80:  NP_Construct is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-07-28 17:12:17 PDT 
Comment on attachment 62894 [details]
Patch

More * issues :(.

Otherwise, r=me.
Comment 4 Anders Carlsson 2010-07-28 17:14:24 PDT 
Committed r64246: <http://trac.webkit.org/changeset/64246>