RESOLVED FIXED 43160
Implement NPN_InvokeDefault and NPN_Construct 
https://bugs.webkit.org/show_bug.cgi?id=43160
Summary Implement NPN_InvokeDefault and NPN_Construct
Anders Carlsson
Reported 2010-07-28 17:00:30 PDT
Implement NPN_InvokeDefault and NPN_Construct
Attachments
Patch (11.39 KB, patch)
2010-07-28 17:04 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-28 17:04:22 PDT
Created attachment 62894 [details] Patch
WebKit Review Bot
Comment 2 2010-07-28 17:06:35 PDT
Attachment 62894 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:551: NPN_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:635: NPN_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:270: NPJSObject::NP_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:291: NPJSObject::NP_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:80: NP_Construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-07-28 17:12:17 PDT
Comment on attachment 62894 [details] Patch More * issues :(. Otherwise, r=me.
Anders Carlsson
Comment 4 2010-07-28 17:14:24 PDT
Committed r64246: <http://trac.webkit.org/changeset/64246>
Note You need to log in before you can comment on or make changes to this bug.