Bug 42986 - Add prompt and confirm client functions to WebKit2
Summary: Add prompt and confirm client functions to WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-07-26 11:50 PDT by Sam Weinig
Modified: 2010-07-26 12:57 PDT (History)
1 user (show)

See Also:

Patch (14.99 KB, patch)
2010-07-26 11:52 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-26 11:50:47 PDT
Add prompt and confirm client functions to WebKit2
Comment 1 Sam Weinig 2010-07-26 11:52:28 PDT
Created attachment 62591 [details]
Comment 2 Anders Carlsson 2010-07-26 11:55:08 PDT
Comment on attachment 62591 [details]

Comment 3 WebKit Review Bot 2010-07-26 11:58:03 PDT
Attachment 62591 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:129:  Extra space between WKPageRunJavaScriptConfirmCallback and runJavaScriptConfirm  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKPage.h:130:  Extra space between WKPageRunJavaScriptPromptCallback and runJavaScriptPrompt  [whitespace/declaration] [3]
WebKit2/UIProcess/WebUIClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2010-07-26 12:57:50 PDT
Fixed in http://trac.webkit.org/changeset/64065.