Bug 42877 - Reserve capacity for attributes
Summary: Reserve capacity for attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-23 00:37 PDT by Adam Barth
Modified: 2010-07-23 12:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2010-07-23 00:39 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (1.90 KB, patch)
2010-07-23 10:12 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-23 00:37:52 PDT 
Reserve capacity for attributes
Comment 1 Adam Barth 2010-07-23 00:39:01 PDT 
Created attachment 62387 [details]
Patch
Comment 2 Adam Barth 2010-07-23 00:39:49 PDT 
Laptop / battery caveat:

== pre ==

Running 20 times
Ignoring warm-up run (4825)
4251
4298
4262
4262
4282
4312
4346
4312
4304
4327
4325
4319
4342
4343
4337
4379
4352
4358
4376
4363

avg 4322.5
stdev 36.51232668565508

== post ==

Running 20 times
Ignoring warm-up run (4734)
4185
4244
4196
4192
4210
4200
4240
4217
4254
4240
4260
4263
4259
4280
4265
4253
4321
4268
4288
4289

avg 4246.2
stdev 35.68697241291281
Comment 3 Eric Seidel (no email) 2010-07-23 05:02:48 PDT 
Comment on attachment 62387 [details]
Patch

Would be ideal to put a comment next to that line explaining how you reached that number 10, and that it's a speedup.
Comment 4 Adam Barth 2010-07-23 09:38:49 PDT 
I just copied it from the old code.  :)
Comment 5 Adam Barth 2010-07-23 10:12:10 PDT 
Created attachment 62441 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-07-23 12:08:55 PDT 
Comment on attachment 62441 [details]
Patch for landing

Clearing flags on attachment: 62441

Committed r63991: <http://trac.webkit.org/changeset/63991>
Comment 7 WebKit Commit Bot 2010-07-23 12:08:59 PDT 
All reviewed patches have been landed.  Closing bug.