Bug 42552 - WebKit2 does not have application cache
Summary: WebKit2 does not have application cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-07-18 22:13 PDT by Maciej Stachowiak
Modified: 2010-07-19 08:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.81 KB, patch)
2010-07-19 08:18 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2010-07-18 22:13:53 PDT 
WebKit2 does not have application cache
Comment 1 Maciej Stachowiak 2010-07-18 22:14:56 PDT 
<rdar://problem/8204936>
Comment 2 Anders Carlsson 2010-07-19 08:18:39 PDT 
Created attachment 61958 [details]
Patch
Comment 3 WebKit Review Bot 2010-07-19 08:21:20 PDT 
Attachment 61958 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/win/WebContextWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2010-07-19 08:23:51 PDT 
Comment on attachment 61958 [details]
Patch

If we implemented localUserSpecificStorageDirectory on Mac, we could share the implementation of WebContext::applicationCacheDirectory.

r=me
Comment 5 Anders Carlsson 2010-07-19 08:42:03 PDT 
Committed r63664: <http://trac.webkit.org/changeset/63664>