WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42520
Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520
Summary
Implement more NPRuntime related NPN_ functions
Anders Carlsson
Reported
2010-07-18 12:23:00 PDT
Implement more NPRuntime related NPN_ functions
Attachments
Patch
(11.69 KB, patch)
2010-07-18 12:28 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-07-18 12:28:14 PDT
Created
attachment 61907
[details]
Patch
WebKit Review Bot
Comment 2
2010-07-18 12:29:40 PDT
Attachment 61907
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:290: NPN_ReleaseObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPRuntimeUtilities.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2010-07-18 12:44:27 PDT
Committed
r63630
: <
http://trac.webkit.org/changeset/63630
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug