Bug 42235 - HTMLTreeBuilder foster parents when it should not
Summary: HTMLTreeBuilder foster parents when it should not
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-13 23:16 PDT by Eric Seidel (no email)
Modified: 2010-07-14 19:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.61 KB, patch)
2010-07-13 23:19 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-13 23:16:09 PDT
HTMLTreeBuilder foster parents when it should not
Comment 1 Eric Seidel (no email) 2010-07-13 23:19:44 PDT
Created attachment 61473 [details]
Patch
Comment 2 Adam Barth 2010-07-13 23:45:19 PDT
Comment on attachment 61473 [details]
Patch

Nice.
Comment 3 WebKit Commit Bot 2010-07-14 06:07:30 PDT
Comment on attachment 61473 [details]
Patch

Rejecting patch 61473 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
ore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLConstructionSite.cpp
Hunk #3 FAILED at 209.
Hunk #4 succeeded at 271 (offset 1 line).
Hunk #5 succeeded at 366 (offset -40 lines).
1 out of 5 hunks FAILED -- saving rejects to file WebCore/html/HTMLConstructionSite.cpp.rej
patching file WebCore/html/HTMLConstructionSite.h
Hunk #1 succeeded at 65 with fuzz 2 (offset -2 lines).
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 succeeded at 1698 (offset 4 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3523174
Comment 4 Eric Seidel (no email) 2010-07-14 11:52:43 PDT
Comment on attachment 61473 [details]
Patch

This should apply now.
Comment 5 WebKit Commit Bot 2010-07-14 18:06:24 PDT
Comment on attachment 61473 [details]
Patch

Clearing flags on attachment: 61473

Committed r63386: <http://trac.webkit.org/changeset/63386>
Comment 6 WebKit Commit Bot 2010-07-14 18:06:28 PDT
All reviewed patches have been landed.  Closing bug.