Bug 42205 - Chromium build files on windows not ignored by git
Summary: Chromium build files on windows not ignored by git
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 14:50 PDT by Vincent Scheib
Modified: 2010-07-14 02:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2010-07-13 17:10 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2010-07-13 14:50:15 PDT
MS Visual Studio solution, project, and other files generated by the GYP build system on windows are not ignored by git.
Comment 1 Vincent Scheib 2010-07-13 15:30:04 PDT
e.g. 
JavaScriptCore/JavaScriptCore.gyp/*.sln
JavaScriptCore/JavaScriptCore.gyp/*.vcproj*
Comment 2 Vincent Scheib 2010-07-13 17:10:45 PDT
Created attachment 61437 [details]
Patch
Comment 3 Kent Tamura 2010-07-13 18:20:20 PDT
Comment on attachment 61437 [details]
Patch

Looks good.
Comment 4 WebKit Commit Bot 2010-07-14 02:55:16 PDT
Comment on attachment 61437 [details]
Patch

Clearing flags on attachment: 61437

Committed r63302: <http://trac.webkit.org/changeset/63302>
Comment 5 WebKit Commit Bot 2010-07-14 02:55:21 PDT
All reviewed patches have been landed.  Closing bug.