Bug 41853 - [Qt] Improve QtWebkit2 secondary process launching procedure
Summary: [Qt] Improve QtWebkit2 secondary process launching procedure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-07-08 06:34 PDT by Luiz Agostini
Modified: 2010-07-08 09:02 PDT (History)
4 users (show)

See Also:

Attachments
patch 1 (12.38 KB, patch)
2010-07-08 06:58 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
patch 2 (12.71 KB, patch)
2010-07-08 08:01 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-07-08 06:34:41 PDT 
[Qt] Improve QtWebkit2 secondary process launching procedure
Comment 1 Luiz Agostini 2010-07-08 06:58:15 PDT 
Created attachment 60873 [details]
patch 1
Comment 2 WebKit Review Bot 2010-07-08 07:00:40 PDT 
Attachment 60873 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp:37:  _qt_takePendingConnection is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:196:  _qt_takePendingConnection is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Luiz Agostini 2010-07-08 08:01:16 PDT 
Created attachment 60881 [details]
patch 2
Comment 4 Antti Koivisto 2010-07-08 08:21:21 PDT 
r=me
Comment 5 WebKit Commit Bot 2010-07-08 09:01:55 PDT 
Comment on attachment 60881 [details]
patch 2

Clearing flags on attachment: 60881

Committed r62790: <http://trac.webkit.org/changeset/62790>
Comment 6 WebKit Commit Bot 2010-07-08 09:02:00 PDT 
All reviewed patches have been landed.  Closing bug.