RESOLVED FIXED 41702
Only export a single WebKitMain function for the Web Process to call 
https://bugs.webkit.org/show_bug.cgi?id=41702
Summary Only export a single WebKitMain function for the Web Process to call
Anders Carlsson
Reported 2010-07-06 09:44:46 PDT
Only export a single WebKitMain function for the Web Process to call
Attachments
Patch (30.31 KB, patch)
2010-07-06 09:50 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-06 09:50:33 PDT
Created attachment 60636 [details] Patch
WebKit Review Bot
Comment 2 2010-07-06 09:54:02 PDT
Attachment 60636 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/WebKitMain.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Shared/win/CommandLineWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/win/WebProcessMainWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/win/WebProcessMainWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-06 10:10:09 PDT
Committed r62560: <http://trac.webkit.org/changeset/62560>
WebKit Review Bot
Comment 4 2010-07-06 10:37:47 PDT
http://trac.webkit.org/changeset/62560 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/62560 http://trac.webkit.org/changeset/62523
Note You need to log in before you can comment on or make changes to this bug.