Bug 41652 - Implement more of InTableMode
Summary: Implement more of InTableMode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-05 23:03 PDT by Adam Barth
Modified: 2010-07-06 01:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.62 KB, patch)
2010-07-05 23:04 PDT, Adam Barth 		eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-05 23:03:15 PDT 
Implement more of InTableMode
Comment 1 Adam Barth 2010-07-05 23:04:26 PDT 
Created attachment 60588 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-05 23:05:23 PDT 
Comment on attachment 60588 [details]
Patch

LGTM.
Comment 3 Adam Barth 2010-07-06 01:06:15 PDT 
Committed r62536: <http://trac.webkit.org/changeset/62536>
Comment 4 WebKit Commit Bot 2010-07-06 01:21:08 PDT 
Comment on attachment 60588 [details]
Patch

Rejecting patch 60588 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Last 500 characters of output:
 5145.
Hunk #25 succeeded at 4382 with fuzz 2 (offset -668 lines).
Hunk #26 FAILED at 4402.
Hunk #27 FAILED at 4595.
Hunk #28 FAILED at 4639.
Hunk #29 succeeded at 4683 (offset -670 lines).
20 out of 29 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 succeeded at 1703 (offset 130 lines).
Hunk #2 succeeded at 1778 (offset 130 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3402297