Bug 41628 - Implement HTML5's "reset insertion mode appropriately"
Summary: Implement HTML5's "reset insertion mode appropriately"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 11:42 PDT by Eric Seidel (no email)
Modified: 2010-07-05 14:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.01 KB, patch)
2010-07-05 11:48 PDT, Eric Seidel (no email) 		abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-05 11:42:48 PDT 
Implement HTML5's "reset insertion mode appropriately"
Comment 1 Eric Seidel (no email) 2010-07-05 11:48:35 PDT 
Created attachment 60563 [details]
Patch
Comment 2 Adam Barth 2010-07-05 12:11:04 PDT 
Comment on attachment 60563 [details]
Patch

At some point we should refactor these while(1) loops.
Comment 3 WebKit Commit Bot 2010-07-05 13:05:52 PDT 
Comment on attachment 60563 [details]
Patch

Rejecting patch 60563 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
-- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #4 FAILED at 1098.
1 out of 4 hunks FAILED -- saving rejects to file WebCore/html/HTMLTreeBuilder.cpp.rej
patching file WebCore/html/HTMLTreeBuilder.h
Hunk #1 FAILED at 190.
Hunk #2 succeeded at 201 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebCore/html/HTMLTreeBuilder.h.rej

Full output: http://webkit-commit-queue.appspot.com/results/3370341
Comment 4 Adam Barth 2010-07-05 14:39:35 PDT 
Committed r62509: <http://trac.webkit.org/changeset/62509>