Bug 41623 - Implement basic text node coalescing
Summary: Implement basic text node coalescing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-05 10:01 PDT by Adam Barth
Modified: 2010-09-29 11:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.48 KB, patch)
2010-07-05 10:05 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (14.35 KB, patch)
2010-07-05 21:11 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-05 10:01:38 PDT 
Implement basic text node coalessing
Comment 1 Adam Barth 2010-07-05 10:05:46 PDT 
Created attachment 60551 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-05 21:04:44 PDT 
Comment on attachment 60551 [details]
Patch

WebCore/dom/CharacterData.cpp:62
 +  PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
We need a bunch more of these parser* functions.

WebCore/dom/CharacterData.h:45
 +      // Similar to appendData, but optimized for the parser (e.g., no mutation
I would have used "Like appendData" to keep it to one 80c line. :)

WebCore/html/HTMLTreeBuilder.cpp:1583
 +              // was the last text node inserted by the parser.
Can we write a test which fails this so we know when we fix it?  Or do we know it's already covered?
Comment 3 Adam Barth 2010-07-05 21:11:23 PDT 
Created attachment 60579 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-07-05 22:15:03 PDT 
Comment on attachment 60579 [details]
Patch for landing

Clearing flags on attachment: 60579

Committed r62520: <http://trac.webkit.org/changeset/62520>
Comment 5 WebKit Commit Bot 2010-07-05 22:15:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-07-06 08:26:44 PDT 
http://trac.webkit.org/changeset/62520 might have broken Leopard Intel Release (Tests)