Bug 4155 – Temporary WebCore SPI necessary for SVG testing tools

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

Temporary WebCore SPI necessary for SVG testing tools.

This adds a few Obj-C wrappers around kcanvas, ksvg2 to allow writing Obj-C based testing tools which 
link against WebCore+SVG.

This SPI is only temporary, and will only exist in WebCore+SVG until SVG is well enough integrated that 
rendering can happen using the normal WebKit draw methods, and dom manipulation can happen through 
the WebKit exposed Obj-C dom classes.

[Eric Seidel (no email)]

Created attachment 3126 [details]
SPI additions necessary for builidng SVG test tools

[John Sullivan]

Comment on attachment 3126 [details]
SPI additions necessary for builidng SVG test tools

Given that this is all temporary code to be used for testing, I didn't review
it really carefully. I did point out a couple of small things worth correcting
on IRC, so I'm giving this a review- and will give the slightly improved
version a review+.

[Eric Seidel (no email)]

Created attachment 3148 [details]
Improved version: (more comments, spelling correction)

I added a bunch of comments, mostly trying to explain some of the hacks
contained in this SPI.	None of this code was ever really meant to "see the
light of day" but I feel that releasing it now will help un-block other aspects
of SVG development, and when things like Obj-C DOM interface generation, or the
WC-DOM/KDOM merge are complete all of this code will be deleted.

[John Sullivan]

Comment on attachment 3148 [details]
Improved version: (more comments, spelling correction)

Checking this in as-is seems fine, given its temporary nature.