Bug 4155 - Temporary WebCore SPI necessary for SVG testing tools
Summary: Temporary WebCore SPI necessary for SVG testing tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 4156 4157
  Show dependency treegraph
 
Reported: 2005-07-26 23:47 PDT by Eric Seidel (no email)
Modified: 2005-07-29 13:39 PDT (History)
0 users

See Also:


Attachments
SPI additions necessary for builidng SVG test tools (81.26 KB, patch)
2005-07-27 17:29 PDT, Eric Seidel (no email)
sullivan: review-
Details | Formatted Diff | Diff
Improved version: (more comments, spelling correction) (82.86 KB, patch)
2005-07-29 12:00 PDT, Eric Seidel (no email)
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-26 23:47:41 PDT
Temporary WebCore SPI necessary for SVG testing tools.

This adds a few Obj-C wrappers around kcanvas, ksvg2 to allow writing Obj-C based testing tools which 
link against WebCore+SVG.

This SPI is only temporary, and will only exist in WebCore+SVG until SVG is well enough integrated that 
rendering can happen using the normal WebKit draw methods, and dom manipulation can happen through 
the WebKit exposed Obj-C dom classes.
Comment 1 Eric Seidel (no email) 2005-07-27 17:29:56 PDT
Created attachment 3126 [details]
SPI additions necessary for builidng SVG test tools
Comment 2 John Sullivan 2005-07-29 11:40:36 PDT
Comment on attachment 3126 [details]
SPI additions necessary for builidng SVG test tools

Given that this is all temporary code to be used for testing, I didn't review
it really carefully. I did point out a couple of small things worth correcting
on IRC, so I'm giving this a review- and will give the slightly improved
version a review+.
Comment 3 Eric Seidel (no email) 2005-07-29 12:00:40 PDT
Created attachment 3148 [details]
Improved version: (more comments, spelling correction)

I added a bunch of comments, mostly trying to explain some of the hacks
contained in this SPI.	None of this code was ever really meant to "see the
light of day" but I feel that releasing it now will help un-block other aspects
of SVG development, and when things like Obj-C DOM interface generation, or the
WC-DOM/KDOM merge are complete all of this code will be deleted.
Comment 4 John Sullivan 2005-07-29 12:05:24 PDT
Comment on attachment 3148 [details]
Improved version: (more comments, spelling correction)

Checking this in as-is seems fine, given its temporary nature.