WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41388
Remove dead binding code
https://bugs.webkit.org/show_bug.cgi?id=41388
Summary
Remove dead binding code
Justin Schuh
Reported
2010-06-29 20:38:40 PDT
Remove dead binding code
Attachments
Patch
(5.46 KB, patch)
2010-06-29 20:46 PDT
,
Justin Schuh
no flags
Details
Formatted Diff
Diff
Patch
(8.55 KB, patch)
2010-06-30 00:20 PDT
,
Justin Schuh
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Justin Schuh
Comment 1
2010-06-29 20:46:14 PDT
Created
attachment 60082
[details]
Patch
WebKit Review Bot
Comment 2
2010-06-29 21:00:35 PDT
Attachment 60082
[details]
did not build on chromium: Build output:
http://webkit-commit-queue.appspot.com/results/3283965
Adam Barth
Comment 3
2010-06-29 22:16:57 PDT
Comment on
attachment 60082
[details]
Patch You probably need to update the gypi
Justin Schuh
Comment 4
2010-06-30 00:18:10 PDT
(In reply to
comment #3
)
> (From update of
attachment 60082
[details]
) > You probably need to update the gypi
D'oh. I do have to update the gypi, but the bot failure is because ExceptionCode.h was being pulled in from BindingElement.h.
Justin Schuh
Comment 5
2010-06-30 00:20:38 PDT
Created
attachment 60091
[details]
Patch
Adam Barth
Comment 6
2010-06-30 01:34:03 PDT
Comment on
attachment 60091
[details]
Patch Much better.
WebKit Commit Bot
Comment 7
2010-06-30 03:11:08 PDT
Comment on
attachment 60091
[details]
Patch Clearing flags on attachment: 60091 Committed
r62174
: <
http://trac.webkit.org/changeset/62174
>
WebKit Commit Bot
Comment 8
2010-06-30 03:11:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug