Bug 41388 - Remove dead binding code
Summary: Remove dead binding code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Justin Schuh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 20:38 PDT by Justin Schuh
Modified: 2010-06-30 03:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2010-06-29 20:46 PDT, Justin Schuh 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2010-06-30 00:20 PDT, Justin Schuh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Schuh 2010-06-29 20:38:40 PDT 
Remove dead binding code
Comment 1 Justin Schuh 2010-06-29 20:46:14 PDT 
Created attachment 60082 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-29 21:00:35 PDT 
Attachment 60082 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3283965
Comment 3 Adam Barth 2010-06-29 22:16:57 PDT 
Comment on attachment 60082 [details]
Patch

You probably need to update the gypi
Comment 4 Justin Schuh 2010-06-30 00:18:10 PDT 
(In reply to comment #3)
> (From update of attachment 60082 [details])
> You probably need to update the gypi

D'oh. I do have to update the gypi, but the bot failure is because ExceptionCode.h was being pulled in from BindingElement.h.
Comment 5 Justin Schuh 2010-06-30 00:20:38 PDT 
Created attachment 60091 [details]
Patch
Comment 6 Adam Barth 2010-06-30 01:34:03 PDT 
Comment on attachment 60091 [details]
Patch

Much better.
Comment 7 WebKit Commit Bot 2010-06-30 03:11:08 PDT 
Comment on attachment 60091 [details]
Patch

Clearing flags on attachment: 60091

Committed r62174: <http://trac.webkit.org/changeset/62174>
Comment 8 WebKit Commit Bot 2010-06-30 03:11:12 PDT 
All reviewed patches have been landed.  Closing bug.