Bug 41251 – REGRESSION(r61943): Totally breaks webkit_unit_tests on Chromium linux and mac (Requested by mnaganov on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/61943 broke the build:
Totally breaks webkit_unit_tests on Chromium linux and mac (Requested by mnaganov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 59839 [details]
ROLLOUT of r61943

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Mikhail Naganov]

I'm very sorry for rolling this out, but it definitely breaks both Linux and Mac webkit_unit_tests on Chromium.

On Linux:

/b/slave/layout_linux/build/src/build/../sconsbuild/Debug/webkit_unit_tests --gtest_print_time
[0626/065336:ERROR:base/file_util.cc(328)] Couldn't open /b/slave/layout_linux/build/src/out/Debug/DumpRenderTree.pak
[0626/065336:ERROR:base/data_pack.cc(59)] Failed to mmap datapack
[0626/065336:FATAL:webkit/support/platform_support_gtk.cc(37)] failed to load DumpRenderTree.pak
Backtrace:
	StackTrace::StackTrace() [0x883cf4e]
	logging::LogMessage::~LogMessage() [0x8840c1b]
	webkit_support::AfterInitialize() [0x8899131]
	webkit_support::SetUpTestEnvironmentImpl() [0x887cd6b]
	webkit_support::SetUpTestEnvironmentForUnitTests() [0x887cd92]
	main [0x80596b4]
	0x40bbb450
	0x80481a1

On Mac:

/b/slave/layout_mac/build/src/xcodebuild/Debug/webkit_unit_tests --gtest_print_time
terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_S_construct NULL not valid

[WebKit Commit Bot]

Comment on attachment 59839 [details]
ROLLOUT of r61943

Clearing flags on attachment: 59839

Committed r61957: <http://trac.webkit.org/changeset/61957>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.