Bug 41076 - Web Inspector: live edit doesn't work when resource tracking is off
Summary: Web Inspector: live edit doesn't work when resource tracking is off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-23 09:47 PDT by Yury Semikhatsky
Modified: 2010-06-24 01:52 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2010-06-23 09:52 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2010-06-23 10:02 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-06-23 09:47:29 PDT 
Live edit doesn't work when resource tracking is off.
Comment 1 Yury Semikhatsky 2010-06-23 09:52:12 PDT 
Created attachment 59522 [details]
Patch
Comment 2 Joseph Pecoraro 2010-06-23 09:57:56 PDT 
Comment on attachment 59522 [details]
Patch

> +++ b/WebCore/inspector/front-end/ScriptView.js=
> +    _sourceIDForLine: function(line) {

Style: Opening brace should be on the next line.


>      // The follow methods are pulled from SourceView, since they are

Could you also change this to "The following methods" as well.
Since its in view =).
Comment 3 Yury Semikhatsky 2010-06-23 10:02:58 PDT 
Created attachment 59523 [details]
Patch
Comment 4 Yury Semikhatsky 2010-06-23 10:03:30 PDT 
(In reply to comment #2)
> (From update of attachment 59522 [details])
> > +++ b/WebCore/inspector/front-end/ScriptView.js=
> > +    _sourceIDForLine: function(line) {
> 
> Style: Opening brace should be on the next line.
> 
Done.

> 
> >      // The follow methods are pulled from SourceView, since they are
> 
> Could you also change this to "The following methods" as well.
> Since its in view =).
Done.
Comment 5 Yury Semikhatsky 2010-06-24 01:52:49 PDT 
Comment on attachment 59523 [details]
Patch

Clearing flags on attachment: 59523

Committed r61747: <http://trac.webkit.org/changeset/61747>
Comment 6 Yury Semikhatsky 2010-06-24 01:52:59 PDT 
All reviewed patches have been landed.  Closing bug.