Bug 40714 - [Qt] Compilation in QWebPagePrivate::timerEvent with clang
Summary: [Qt] Compilation in QWebPagePrivate::timerEvent with clang
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2010-06-16 08:58 PDT by Olivier Goffart
Modified: 2011-04-19 05:15 PDT (History)
3 users (show)

See Also:

Patch (1.73 KB, patch)
2010-06-16 09:10 PDT, Olivier Goffart
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Goffart 2010-06-16 08:58:42 PDT
QtWebkit: Fix compilaiton with clang.
    QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
    with clang
    QWebPagePrivate is a friend of QWebPage and then should have access to
    all protected members of parents of QWebPage, including QObject.
    But the clang team do not want to conform to this aspect of the specification
    because "It is either a drafting error or a horrible mistake."
    See http://llvm.org/bugs/show_bug.cgi?id=6840
    This change is better because QWebPage does not reimplement the timerEvent
    (QWebPagePrivate::timerEvent is called from QWebPage::event)
    So customers that would reimplement their own timerEvent
    for their own timer now get a chance to catch them.
Comment 1 Olivier Goffart 2010-06-16 09:10:12 PDT
Created attachment 58897 [details]
Comment 2 Kenneth Rohde Christiansen 2010-06-16 09:59:39 PDT
Comment on attachment 58897 [details]

Yes I read the thread on the clang bug report and mailing list some time ago :-) r=me!
Comment 3 WebKit Commit Bot 2010-06-19 03:04:10 PDT
Comment on attachment 58897 [details]

Clearing flags on attachment: 58897

Committed r61476: <http://trac.webkit.org/changeset/61476>
Comment 4 WebKit Commit Bot 2010-06-19 03:04:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-06-19 08:46:04 PDT
Revision r61476 cherry-picked into qtwebkit-2.0 with commit b44934b2fd56c3e9e19bd9e7d0d0a341d442b195