Bug 40714 – [Qt] Compilation in QWebPagePrivate::timerEvent with clang

• Status: CLOSED
• Resolution: FIXED
• Component: WebKit Qt

[Olivier Goffart]

QtWebkit: Fix compilaiton with clang.
    
    QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
    with clang
    
    QWebPagePrivate is a friend of QWebPage and then should have access to
    all protected members of parents of QWebPage, including QObject.
    But the clang team do not want to conform to this aspect of the specification
    because "It is either a drafting error or a horrible mistake."
    See http://llvm.org/bugs/show_bug.cgi?id=6840
    
    This change is better because QWebPage does not reimplement the timerEvent
    (QWebPagePrivate::timerEvent is called from QWebPage::event)
    So customers that would reimplement their own timerEvent
    for their own timer now get a chance to catch them.

[Olivier Goffart]

Created attachment 58897 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 58897 [details]
Patch

Yes I read the thread on the clang bug report and mailing list some time ago :-) r=me!

[WebKit Commit Bot]

Comment on attachment 58897 [details]
Patch

Clearing flags on attachment: 58897

Committed r61476: <http://trac.webkit.org/changeset/61476>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Revision r61476 cherry-picked into qtwebkit-2.0 with commit b44934b2fd56c3e9e19bd9e7d0d0a341d442b195