Bug 40528 - vim splash screen when using webkit-patch upload --git-commit=HEAD
Summary: vim splash screen when using webkit-patch upload --git-commit=HEAD
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-06-12 11:06 PDT by Robert Hogan
Modified: 2010-06-12 14:17 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-06-12 11:06:47 PDT
When I try to use webkit-patch to create a new bug and attach a patch to it, I'm asked to enter the title of the new bug then next get a blank vim screen, well 'blank' in that it's the splash vim screen instructing how you to get started with using vim. I try entering text in it fine. But :x and :w tell me that I can't save my changes.

Presumably this screen should be displaying the changelogs to me so I can update them.
Comment 1 Robert Hogan 2010-06-12 11:23:42 PDT
So this is what my attempt looks like. In the case below, I tried :e newfile, bit of editing and then :x. No changelog was included in the uploaded patch.

robert@mwenge:~/Development/WebKit$ WebKitTools/Scripts/webkit-patch upload --git-commit=HEAD
Running check-webkit-style
Total errors found: 0 in 1 files
Please enter a bug number or a title for a new bug:
[Qt] Use backspace for eventSender.keyDown("delete")
bugs.webkit.org login: robert@webkit.org
bugs.webkit.org password for robert@webkit.org: 
Logging in as robert@webkit.org...
Creating bug with title "[Qt] Use backspace for eventSender.keyDown("delete")"
Bug 40529 created.
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Extracting affected function names from source files.
  Change author: Robert Hogan <robert@webkit.org>.
  Description from bug 40529:
    "[Qt] Use backspace for eventSender.keyDown("delete")".
  Editing the WebKitTools/ChangeLog file.
  Editing the LayoutTests/ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry. --
-- See <http://webkit.org/coding/contributing.html> for more info --

[No write since last change]
/bin/bash: e: command not found

shell returned 127

Press ENTER or type command to continue
Was that diff correct? [Y/n]:
Comment 2 Robert Hogan 2010-06-12 11:24:16 PDT
I guess it should be opening up the changelogs for editing but is not.