Bug 40513 - Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
Summary: Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 40491
  Show dependency tree / graph
 
Reported: 2010-06-11 18:49 PDT by Eric Seidel (no email)
Modified: 2010-06-13 21:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.15 KB, patch)
2010-06-11 18:52 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (5.13 KB, patch)
2010-06-13 17:26 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (5.14 KB, patch)
2010-06-13 17:31 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-11 18:49:53 PDT 
Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
Comment 1 Eric Seidel (no email) 2010-06-11 18:52:08 PDT 
Created attachment 58538 [details]
Patch
Comment 2 WebKit Commit Bot 2010-06-12 10:39:32 PDT 
Comment on attachment 58538 [details]
Patch

Rejecting patch 58538 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1
Last 500 characters of output:
o this was:
--------------------------
|Index: WebCore/html/HTMLDocumentParser.h
|index 9ccebe5dc17668f3082dee5bb7ebfd9f391d216c..0951c2a358d0d81416792931e1601a2941b2af1c 100644
|--- WebCore/html/HTMLDocumentParser.h
|+++ WebCore/html/HTMLDocumentParser.h
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file WebCore/loader/DocumentLoader.cpp
Hunk #1 FAILED at 393.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/DocumentLoader.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3183377
Comment 3 WebKit Commit Bot 2010-06-13 00:26:50 PDT 
Comment on attachment 58538 [details]
Patch

Rejecting patch 58538 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1
Last 500 characters of output:
unk #1 succeeded at 1 with fuzz 3.
patching file WebCore/dom/Document.cpp
Hunk #1 FAILED at 1958.
Hunk #2 FAILED at 1966.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/dom/Document.cpp.rej
patching file WebCore/dom/DocumentParser.h
patching file WebCore/html/HTMLDocumentParser.cpp
patching file WebCore/html/HTMLDocumentParser.h
patching file WebCore/loader/DocumentLoader.cpp
Hunk #1 FAILED at 393.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/DocumentLoader.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3273026
Comment 4 Eric Seidel (no email) 2010-06-13 17:25:27 PDT 
Comment on attachment 58538 [details]
Patch

One more try now that I've updated bug 40512.
Comment 5 Eric Seidel (no email) 2010-06-13 17:26:55 PDT 
Created attachment 58606 [details]
Patch for landing
Comment 6 Eric Seidel (no email) 2010-06-13 17:31:29 PDT 
Created attachment 58607 [details]
Patch for landing
Comment 7 Adam Barth 2010-06-13 21:44:39 PDT 
Comment on attachment 58607 [details]
Patch for landing

Clearing flags on attachment: 58607

Committed r61105: <http://trac.webkit.org/changeset/61105>
Comment 8 Adam Barth 2010-06-13 21:44:46 PDT 
All reviewed patches have been landed.  Closing bug.