Bug 40427 - [Qt] There should be a way to enable popups in QtTestBrowser
Summary: [Qt] There should be a way to enable popups in QtTestBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-06-10 10:12 PDT by Yael
Modified: 2010-06-11 01:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.22 KB, patch)
2010-06-10 10:17 PDT, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-06-10 10:12:15 PDT
Some layout tests open a second window during the test. Currently, there is no way to run those tests, since QtTestBrowser blocks all popups.
Comment 1 Yael 2010-06-10 10:17:06 PDT
Created attachment 58380 [details]
Patch
Comment 2 Laszlo Gombos 2010-06-10 12:48:51 PDT
Comment on attachment 58380 [details]
Patch

looks good, r+.
Comment 3 WebKit Commit Bot 2010-06-11 01:41:19 PDT
Comment on attachment 58380 [details]
Patch

Clearing flags on attachment: 58380

Committed r60997: <http://trac.webkit.org/changeset/60997>
Comment 4 WebKit Commit Bot 2010-06-11 01:41:27 PDT
All reviewed patches have been landed.  Closing bug.