WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40219
[Mac] ENABLE_METER_TAG should be enabled
https://bugs.webkit.org/show_bug.cgi?id=40219
Summary
[Mac] ENABLE_METER_TAG should be enabled
Hajime Morrita
Reported
2010-06-06 23:27:49 PDT
Once <meter> gets the native look and feel, It should be enabled.
Attachments
patch v0
(15.03 KB, patch)
2010-06-07 00:19 PDT
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
patch v1
(17.11 KB, patch)
2010-06-07 01:43 PDT
,
Hajime Morrita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2010-06-07 00:19:26 PDT
Created
attachment 57998
[details]
patch v0
Kent Tamura
Comment 2
2010-06-07 00:32:24 PDT
Comment on
attachment 57998
[details]
patch v0 We have to update WebKit2/Configurations/FeatureDefines.xcconfig too. WebCore/ChangeLog:1 + 2010-06-06 MORITA Hajime <
morrita@google.com
>b nit: The trailing 'b' is unnecessary.
Hajime Morrita
Comment 3
2010-06-07 01:43:24 PDT
Created
attachment 58001
[details]
patch v1
Hajime Morrita
Comment 4
2010-06-07 01:44:11 PDT
Hi, thank you for reviewing!
> (From update of
attachment 57998
[details]
) > We have to update WebKit2/Configurations/FeatureDefines.xcconfig too.
Done.
> > WebCore/ChangeLog:1 > + 2010-06-06 MORITA Hajime <
morrita@google.com
>b > nit: The trailing 'b' is unnecessary.
Oops. removed...
Kent Tamura
Comment 5
2010-06-07 01:47:17 PDT
Comment on
attachment 58001
[details]
patch v1 OK. The diff for WebCore/ChangeLog is not in usual diff format of ChangeLog. Please take care when you commit this patch.
Hajime Morrita
Comment 6
2010-06-07 02:23:03 PDT
Thank you for reviewing.
> The diff for WebCore/ChangeLog is not in usual diff format of ChangeLog. Please take care when you commit this patch.
OK. I'll land this after the patch for
Bug 40217
get granted.
Hajime Morrita
Comment 7
2010-06-07 22:03:37 PDT
Committed
r60820
: <
http://trac.webkit.org/changeset/60820
>
Hajime Morrita
Comment 8
2010-06-07 22:24:25 PDT
Committed
r60821
: <
http://trac.webkit.org/changeset/60821
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug