Bug 40219 - [Mac] ENABLE_METER_TAG should be enabled
Summary: [Mac] ENABLE_METER_TAG should be enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 40217
Blocks: 37074
  Show dependency treegraph
 
Reported: 2010-06-06 23:27 PDT by Hajime Morrita
Modified: 2010-06-07 22:24 PDT (History)
0 users

See Also:


Attachments
patch v0 (15.03 KB, patch)
2010-06-07 00:19 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
patch v1 (17.11 KB, patch)
2010-06-07 01:43 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-06-06 23:27:49 PDT
Once <meter> gets the native look and feel, It should be enabled.
Comment 1 Hajime Morrita 2010-06-07 00:19:26 PDT
Created attachment 57998 [details]
patch v0
Comment 2 Kent Tamura 2010-06-07 00:32:24 PDT
Comment on attachment 57998 [details]
patch v0

We have to update WebKit2/Configurations/FeatureDefines.xcconfig too.

WebCore/ChangeLog:1
 +  2010-06-06  MORITA Hajime  <morrita@google.com>b
nit: The trailing 'b' is unnecessary.
Comment 3 Hajime Morrita 2010-06-07 01:43:24 PDT
Created attachment 58001 [details]
patch v1
Comment 4 Hajime Morrita 2010-06-07 01:44:11 PDT
Hi, thank you for reviewing!

> (From update of attachment 57998 [details])
> We have to update WebKit2/Configurations/FeatureDefines.xcconfig too.
Done.

> 
> WebCore/ChangeLog:1
>  +  2010-06-06  MORITA Hajime  <morrita@google.com>b
> nit: The trailing 'b' is unnecessary.
Oops. removed...
Comment 5 Kent Tamura 2010-06-07 01:47:17 PDT
Comment on attachment 58001 [details]
patch v1

OK.
The diff for WebCore/ChangeLog is not in usual diff format of ChangeLog.  Please take care when you commit this patch.
Comment 6 Hajime Morrita 2010-06-07 02:23:03 PDT
Thank you for reviewing.
> The diff for WebCore/ChangeLog is not in usual diff format of ChangeLog.  Please take care when you commit this patch.
OK. 
I'll land this after the patch for Bug 40217 get granted.
Comment 7 Hajime Morrita 2010-06-07 22:03:37 PDT
Committed r60820: <http://trac.webkit.org/changeset/60820>
Comment 8 Hajime Morrita 2010-06-07 22:24:25 PDT
Committed r60821: <http://trac.webkit.org/changeset/60821>