Bug 39878 – [Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Raine Makelainen]

Created attachment 57335 [details]
Proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum.

WebKit/qt/Api/qwebsettings.h has a wrong case in JavascriptCanAccessClipboard. Currently WebKit/qt/Api/qwebsettings.h has QWebSettings::JavaScriptCanAccessClipboard instead of QWebSettings::JavascriptCanAccessClipboard. Thus, causing API break.

According to current documentation, it should be QWebSettings::JavascriptCanAccessClipboard, same with older 4.6 docs.
http://doc.trolltech.com/4.7-snapshot/qwebsettings.html
http://doc.trolltech.com/4.6/qwebsettings.html

[Simon Hausmann]

Comment on attachment 57335 [details]
Proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum.

Raine, I think your patch is on the right track but not entirely correct. r58703 also added the DOMPasteAllowed enum. I think the correct patch would revert that part of r58703 and store JavascriptCanAccessClipboard at the old position.

[Raine Makelainen]

(In reply to comment #1)
> (From update of attachment 57335 [details])
> Raine, I think your patch is on the right track but not entirely correct. r58703 also added the DOMPasteAllowed enum. I think the correct patch would revert that part of r58703 and store JavascriptCanAccessClipboard at the old position.

Thanks, for comments, I'll incorporate comments. Should we leave call to WebCore::Settings::setDOMPasteAllowed(false) or similar at qwebsettings.cpp. What do you think?

[Raine Makelainen]

Created attachment 57456 [details]
2nd proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum. 

Review comments from Simon merged.

[Simon Hausmann]

(In reply to comment #3)
> Created an attachment (id=57456) [details]
> 2nd proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum. 
> 
> Review comments from Simon merged.

If you would like your patch to be included in WebKit, please mark it up for review (set review?) so that it can be reviewed.

You might also want to consider setting the commit-queue flag (http://trac.webkit.org/wiki/CommitQueue)

[Simon Hausmann]

Comment on attachment 57456 [details]
2nd proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum. 

Thanks Raine :)

I think the patch looks good, but please add ChangeLog entries. You can use WebKitTools/Scripts/prepare-ChangeLog for that. r- because of that, the rest looks good to me.

[Raine Makelainen]

Created attachment 57529 [details]
Proposal 3 for fixing QWebSettings::JavascriptCanAccessClipboard enum.

ChangeLogs added.

[Simon Hausmann]

Comment on attachment 57529 [details]
Proposal 3 for fixing QWebSettings::JavascriptCanAccessClipboard enum.

r=me. Welcome Raine to WebKit development :)

[Kenneth Rohde Christiansen]

Good work Raine!

[WebKit Commit Bot]

Comment on attachment 57529 [details]
Proposal 3 for fixing QWebSettings::JavascriptCanAccessClipboard enum.

Clearing flags on attachment: 57529

Committed r60525: <http://trac.webkit.org/changeset/60525>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.