Bug 39328 - chromium: revert r58765 to test a performance regression
Summary: chromium: revert r58765 to test a performance regression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 39379
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-18 16:00 PDT by Dirk Pranke
Modified: 2010-05-19 14:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.99 KB, patch)
2010-05-18 16:12 PDT, Dirk Pranke
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-05-18 16:00:49 PDT
Something in a webkit roll two weeks ago seemed to cause a performance regression in chromium. So far, it looks like it's caused by http://trac.webkit.org/changeset/58765 , although I have no idea why (and neither does johnnyg ). We'll try reverting the change to see if that speeds up the tests or not.
Comment 1 Dirk Pranke 2010-05-18 16:12:21 PDT
Created attachment 56420 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-18 16:40:13 PDT
Attachment 56420 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2312298
Comment 3 Dimitri Glazkov (Google) 2010-05-19 12:22:27 PDT
Comment on attachment 56420 [details]
Patch

ok.
Comment 4 Dirk Pranke 2010-05-19 13:41:19 PDT
Committed r59782: <http://trac.webkit.org/changeset/59782>
Comment 5 WebKit Review Bot 2010-05-19 13:58:52 PDT
http://trac.webkit.org/changeset/59782 might have broken Chromium Linux Release