Bug 39180 - Reduce the size of FunctionExecutable
Summary: Reduce the size of FunctionExecutable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-05-16 10:42 PDT by Simon Fraser (smfr)
Modified: 2010-05-16 18:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.21 KB, patch)
2010-05-16 12:13 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-05-16 10:42:31 PDT
FunctionExecutable could be shrunkerated. m_numVariables can be an int, etc.
Comment 1 Simon Fraser (smfr) 2010-05-16 12:13:14 PDT
Created attachment 56191 [details]
Patch
Comment 2 Darin Adler 2010-05-16 12:14:49 PDT
Comment on attachment 56191 [details]
Patch

> +        int variableCount() const { return m_numVariables; }

Why int rather than unsigned?

> +        int m_numVariables : 31;

Same question here.

r=me
Comment 3 Simon Fraser (smfr) 2010-05-16 18:03:10 PDT
http://trac.webkit.org/changeset/59587
Comment 4 Simon Fraser (smfr) 2010-05-16 18:04:03 PDT
<rdar://problem/7990529>