Bug 39141 - Only use rietveld mode when in-rietveld is set to +
Summary: Only use rietveld mode when in-rietveld is set to +
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 15:10 PDT by Julie Parent
Modified: 2010-05-14 16:13 PDT (History)
0 users

See Also:

Attachments
patch. (1.27 KB, patch)
2010-05-14 15:58 PDT, Julie Parent 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2010-05-14 15:10:13 PDT 
Currently uses presence of flag, not the value of it, so shows the "Rietveld Review" link even if the in-rietveld flag is -.
Comment 1 Julie Parent 2010-05-14 15:58:29 PDT 
Created attachment 56117 [details]
patch.
Comment 2 Julie Parent 2010-05-14 16:13:47 PDT 
Committed in http://trac.webkit.org/changeset/59501