Bug 39000 - [chromium] Make ImageDiff depend on webkit (again).
Summary: [chromium] Make ImageDiff depend on webkit (again).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 09:22 PDT by jochen
Modified: 2010-05-14 05:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2010-05-12 09:24 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2010-05-12 09:22:47 PDT 
Make ImageDiff depend on webkit (again).
Comment 1 jochen 2010-05-12 09:24:26 PDT 
Created attachment 55856 [details]
Patch
Comment 2 jochen 2010-05-12 09:26:24 PDT 
ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread.

I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :(
Comment 3 Eric Seidel (no email) 2010-05-12 12:19:47 PDT 
Comment on attachment 55856 [details]
Patch

OK.
Comment 4 Tony Chang 2010-05-12 17:25:41 PDT 
(In reply to comment #2)
> ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread.
> 
> I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :(

Sorry about dropping this when moving the target!
Comment 5 WebKit Commit Bot 2010-05-14 05:28:25 PDT 
Comment on attachment 55856 [details]
Patch

Clearing flags on attachment: 55856

Committed r59467: <http://trac.webkit.org/changeset/59467>
Comment 6 WebKit Commit Bot 2010-05-14 05:28:30 PDT 
All reviewed patches have been landed.  Closing bug.