RESOLVED FIXED 39000
[chromium] Make ImageDiff depend on webkit (again). 
https://bugs.webkit.org/show_bug.cgi?id=39000
Summary [chromium] Make ImageDiff depend on webkit (again).
jochen
Reported 2010-05-12 09:22:47 PDT
Make ImageDiff depend on webkit (again).
Attachments
Patch (1.07 KB, patch)
2010-05-12 09:24 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-05-12 09:24:26 PDT
Created attachment 55856 [details] Patch
jochen
Comment 2 2010-05-12 09:26:24 PDT
ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread. I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :(
Eric Seidel (no email)
Comment 3 2010-05-12 12:19:47 PDT
Comment on attachment 55856 [details] Patch OK.
Tony Chang
Comment 4 2010-05-12 17:25:41 PDT
(In reply to comment #2) > ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread. > > I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :( Sorry about dropping this when moving the target!
WebKit Commit Bot
Comment 5 2010-05-14 05:28:25 PDT
Comment on attachment 55856 [details] Patch Clearing flags on attachment: 55856 Committed r59467: <http://trac.webkit.org/changeset/59467>
WebKit Commit Bot
Comment 6 2010-05-14 05:28:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.