WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
38996
[Chromium] Rebaseline storage/domstorage/quota.html
https://bugs.webkit.org/show_bug.cgi?id=38996
Summary
[Chromium] Rebaseline storage/domstorage/quota.html
Hans Wennborg
Reported
2010-05-12 08:34:01 PDT
[Chromium] Rebaseline storage/domstorage/quota.html
Attachments
Patch
(1.95 KB, patch)
2010-05-12 08:35 PDT
,
Hans Wennborg
no flags
Details
Formatted Diff
Diff
Patch
(3.18 KB, patch)
2010-05-12 09:30 PDT
,
Hans Wennborg
no flags
Details
Formatted Diff
Diff
Patch
(3.27 KB, patch)
2010-05-12 09:33 PDT
,
Hans Wennborg
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Hans Wennborg
Comment 1
2010-05-12 08:35:35 PDT
Created
attachment 55850
[details]
Patch
Jeremy Orlow
Comment 2
2010-05-12 08:42:27 PDT
+ Dimitri for a sanity check
Jeremy Orlow
Comment 3
2010-05-12 08:43:30 PDT
Comment on
attachment 55850
[details]
Patch Although what you did here makes sense, my understanding is that all baselines should be in platform/chromium-mac and platform/chromium-win. I know this is weird and duplication, but I believe what the rebaslining tool does by default is what we want. Dimitri, and I wrong?
Dimitri Glazkov (Google)
Comment 4
2010-05-12 09:00:23 PDT
Jeremy's right! Please use rebaselining tool to create baselines. That's your best bet to do it painlessly:
http://trac.webkit.org/wiki/Rebaseline
Hans Wennborg
Comment 5
2010-05-12 09:30:42 PDT
Created
attachment 55858
[details]
Patch
Hans Wennborg
Comment 6
2010-05-12 09:33:17 PDT
Created
attachment 55860
[details]
Patch
Jeremy Orlow
Comment 7
2010-05-14 02:23:57 PDT
Comment on
attachment 55860
[details]
Patch Clearing flags on attachment: 55860 Committed
r59457
: <
http://trac.webkit.org/changeset/59457
>
Jeremy Orlow
Comment 8
2010-05-14 02:24:06 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug