Bug 38941 - build-webkit shouldn’t override ENABLE_FOO Xcode configuration settings
Summary: build-webkit shouldn’t override ENABLE_FOO Xcode configuration settings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-05-11 15:36 PDT by Mark Rowe (bdash)
Modified: 2010-05-11 16:13 PDT (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2010-05-11 15:36:19 PDT
build-webkit always passes every ENABLE_FOO macro that it knows about through to xcodebuild.  This leads to the default values in FeatureDefines.xcconfig being ignored.  Since build-webkit is used solely by OpenSource-only builds this results in non-obvious problems:
1) Mismatched ENABLE_FOO settings across projects are not apparent.
2) Inconsistent default values between build-webkit and FeatureDefines.xcconfig results in world builds when switching between the different means of building.

build-webkit should only be passing ENABLE_FOO settings to xcodebuild if their values are explicitly being overridden.
Comment 1 Mark Rowe (bdash) 2010-05-11 15:37:29 PDT
The symptoms of 1) are particularly nasty: vtable layouts for classes can differ between projects, which at worst results in mysterious behavior but often simply results in a crash on launch.
Comment 2 Mark Rowe (bdash) 2010-05-11 16:13:25 PDT
I landed a change in r59181 that has build-webkit not pass ENABLE_FOO settings to xcodebuild if the value matches the default.  This should help reveal both classes of issue.