RESOLVED INVALID38461
[GStreamer] forgotten call to durationChanged in updateStates() 
https://bugs.webkit.org/show_bug.cgi?id=38461
Summary [GStreamer] forgotten call to durationChanged in updateStates()
Philippe Normand
Reported 2010-05-03 07:19:56 PDT
when pipeline rolls to PLAYING we do a duration query and if it succeeds we don't call durationChanged() to notify the MediaPlayer.
Attachments
proposed patch (1.82 KB, patch)
2010-05-03 07:42 PDT, Philippe Normand 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-03 07:42:32 PDT
Created attachment 54926 [details] proposed patch
Philippe Normand
Comment 2 2010-05-03 11:02:23 PDT
Landed in r58685
Eric Seidel (no email)
Comment 3 2010-05-03 11:17:47 PDT
This failed to update the Gtk results and is causing failures on the bots.
WebKit Review Bot
Comment 4 2010-05-03 11:19:35 PDT
http://trac.webkit.org/changeset/58685 might have broken GTK Linux 32-bit Release
Eric Seidel (no email)
Comment 5 2010-05-03 11:50:31 PDT
Reverted r58685 for reason: Broke a test on Gtk Committed r58690: <http://trac.webkit.org/changeset/58690>
Eric Seidel (no email)
Comment 6 2010-05-03 11:52:22 PDT
Comment on attachment 54926 [details] proposed patch r- as this was rolled out. I suspect it just needed a Gtk test update. However Phillipe seemed unsure, so I went ahead and rolled it out to re-green the tree while he and Eric decide the proper course of action.
Philippe Normand
Comment 7 2010-05-13 02:49:54 PDT
This patch was wrong indeed. durationchanged was emitted but the duration() result didn't actually change. The if changed by the patch is meant to cache the duration in a private member. BTW I noticed we could do that step when the player enters to PAUSED, it would spare some uneeded queries between PAUSED->PLAYING. Will open a new bug for this :)
Note You need to log in before you can comment on or make changes to this bug.