RESOLVED FIXED 38449
Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js 
https://bugs.webkit.org/show_bug.cgi?id=38449
Summary Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
Joseph Pecoraro
Reported 2010-05-02 23:34:41 PDT
The *.re2js files are preprocessed to produce their *.js counterparts. There is no need for them to be copied when building.
Attachments
[PATCH] Proposed Fix (1.23 KB, patch)
2010-05-02 23:36 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[DRAFT] Copy localizedStrings.js for Mac OS X (2.41 KB, patch)
2010-05-02 23:55 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-05-02 23:36:16 PDT
Created attachment 54906 [details] [PATCH] Proposed Fix Also, the localizedStrings file might be useful to copy over, seeing as it is used by the Inspector.
Joseph Pecoraro
Comment 2 2010-05-02 23:55:37 PDT
Created attachment 54907 [details] [DRAFT] Copy localizedStrings.js for Mac OS X This is not up for review that copies over the localizedStrings.js file for OS X systems. Anyone know where it goes for Windows and other platforms? Maybe then it would be worth landing?
Pavel Feldman
Comment 3 2010-05-05 12:09:12 PDT
Comment on attachment 54906 [details] [PATCH] Proposed Fix Should we move re2js files out of the folder longer term?
Joseph Pecoraro
Comment 4 2010-05-05 19:39:25 PDT
(In reply to comment #3) > (From update of attachment 54906 [details]) > Should we move re2js files out of the folder longer term? Maybe move them into WebCore/inspector instead of WebCore/inspector/front-end?
Timothy Hatcher
Comment 5 2010-05-05 20:58:38 PDT
I think staying in WebCore/inspector/front-end is fine, it keeps them next to the generated version.
WebKit Commit Bot
Comment 6 2010-05-06 00:05:18 PDT
Comment on attachment 54906 [details] [PATCH] Proposed Fix Clearing flags on attachment: 54906 Committed r58868: <http://trac.webkit.org/changeset/58868>
WebKit Commit Bot
Comment 7 2010-05-06 00:05:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.