Bug 38200 - run-bindings-tests should use --reset-results instead of --overwrite
Summary: run-bindings-tests should use --reset-results instead of --overwrite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 07:35 PDT by Ojan Vafai
Modified: 2010-04-27 14:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2010-04-27 10:14 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-04-27 07:35:42 PDT
That would make it consistent with run-webkit-tests, which seems like a good thing.
Comment 1 Adam Barth 2010-04-27 10:14:20 PDT
Created attachment 54426 [details]
Patch
Comment 2 Darin Adler 2010-04-27 12:53:36 PDT
Comment on attachment 54426 [details]
Patch

OK
Comment 3 Adam Barth 2010-04-27 13:25:14 PDT
Comment on attachment 54426 [details]
Patch

Clearing flags on attachment: 54426

Committed r58329: <http://trac.webkit.org/changeset/58329>
Comment 4 Adam Barth 2010-04-27 13:25:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-04-27 13:50:56 PDT
http://trac.webkit.org/changeset/58329 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58329
http://trac.webkit.org/changeset/58330
http://trac.webkit.org/changeset/58331