Bug 38035 - Add a test for file URL canonicalization with an http base
Summary: Add a test for file URL canonicalization with an http base
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 23:42 PDT by Maciej Stachowiak
Modified: 2010-04-23 00:00 PDT (History)
0 users

See Also:


Attachments
Patch (7.72 KB, patch)
2010-04-22 23:49 PDT, Maciej Stachowiak
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2010-04-22 23:42:31 PDT
Add a test for file URL canonicalization with an http base
Comment 1 Maciej Stachowiak 2010-04-22 23:49:48 PDT
Created attachment 54136 [details]
Patch
Comment 2 Adam Barth 2010-04-22 23:53:21 PDT
Comment on attachment 54136 [details]
Patch

LGTM.  If you wanted to be really sporting, you'd break out the windows and unix parts of the test into different files, but this is fine.
Comment 3 Maciej Stachowiak 2010-04-22 23:58:18 PDT
I left the file-base ones in the same file too, so leaving the test like this for now.
Comment 4 Maciej Stachowiak 2010-04-23 00:00:50 PDT
Committed r58152: <http://trac.webkit.org/changeset/58152>