RESOLVED FIXED Bug 37988
Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
https://bugs.webkit.org/show_bug.cgi?id=37988
Summary Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with t...
Alexander Pavlov (apavlov)
Reported 2010-04-22 05:58:12 PDT
If there is an "Image Dimensions" audit violation and the image URL is a complete http://foo-type URL, it will be prefixed with the page name (like, home/http://foo) in the audit results.
Attachments
[PATCH] Suggested fix (1.83 KB, patch)
2010-04-22 06:10 PDT, Alexander Pavlov (apavlov)
no flags
[PATCH] Comments addressed (1.79 KB, patch)
2010-04-22 09:41 PDT, Alexander Pavlov (apavlov)
no flags
Alexander Pavlov (apavlov)
Comment 1 2010-04-22 06:10:07 PDT
Created attachment 54055 [details] [PATCH] Suggested fix
Joseph Pecoraro
Comment 2 2010-04-22 08:28:02 PDT
Comment on attachment 54055 [details] [PATCH] Suggested fix > + var srcMatch = src.match(WebInspector.URLRegExp); > + if (!srcMatch) { You don't use the match object, you're just testing. This can be: if (!WebInspector.URLRegExp.test(src)) {
Alexander Pavlov (apavlov)
Comment 3 2010-04-22 09:41:19 PDT
Created attachment 54068 [details] [PATCH] Comments addressed
WebKit Commit Bot
Comment 4 2010-04-23 06:05:12 PDT
Comment on attachment 54068 [details] [PATCH] Comments addressed Clearing flags on attachment: 54068 Committed r58163: <http://trac.webkit.org/changeset/58163>
WebKit Commit Bot
Comment 5 2010-04-23 06:05:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.