Bug 37638 - webkit-patch opens the ".html" diff file in my text editor, and gave errors about the png file
Summary: webkit-patch opens the ".html" diff file in my text editor, and gave errors a...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-14 21:35 PDT by Simon Fraser (smfr)
Modified: 2010-04-14 21:36 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-04-14 21:35:31 PDT 
Two issues with webkit-patch:
1. The recent change to show the diff as a pretty html file breaks if, on Mac OS X, you set the owner of ".html" files to a text editor. It just opens the .html file in a text editor, leading to confusion.

2. My patch included an new image result. The diff contained:

LayoutTests/platform/mac/fast/repaint/fixed-tranformed-expected.png

Exception raised during decoding git binary patch:
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:67:in `exec': No such file or directory - /opt/local/bin/git apply --directory=/var/folders/OZ/OZ58r8WF2RaEz++1YxQZGU+++TI/-Tmp- (Errno::ENOENT)
	from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:67:in `popen3'
	from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:53:in `fork'
	from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:53:in `popen3'
	from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:51:in `fork'
	from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/open3.rb:51:in `popen3'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:337:in `extract_contents_from_git_binary_chunk'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:258:in `initialize'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in `collect'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in `initialize'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `new'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `collect'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:15:in `prettify'
	from /Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/prettify.rb:26

/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:343:in `extract_contents_from_git_binary_chunk'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:258:in `initialize'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in `collect'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:257:in `initialize'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `new'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `collect'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:309:in `parse'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/PrettyPatch.rb:15:in `prettify'
/Volumes/WebKit/WebKit.git/BugsSite/PrettyPatch/prettify.rb:26