Bug 37519 - Teach webkit-patch how to handle revisions missing ChangeLogs
Summary: Teach webkit-patch how to handle revisions missing ChangeLogs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 13:57 PDT by Eric Seidel (no email)
Modified: 2010-04-14 02:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.73 KB, patch)
2010-04-13 14:00 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-04-13 13:57:04 PDT 
Teach webkit-patch how to handle revisions missing ChangeLogs
Comment 1 Eric Seidel (no email) 2010-04-13 14:00:17 PDT 
Created attachment 53276 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-13 14:01:34 PDT 
This fixes the exception Adam Roben hit when trying to run failure-reason yesterday.
Comment 3 Adam Barth 2010-04-13 14:37:57 PDT 
Comment on attachment 53276 [details]
Patch

good point.
Comment 4 Eric Seidel (no email) 2010-04-13 14:47:36 PDT 
I don't really like this current handling, especially due to the copy/paste logging code.  But I'm not sure CommitInfo even makes sense w/o ChangeLogs. :)
Comment 5 WebKit Commit Bot 2010-04-14 02:01:07 PDT 
Comment on attachment 53276 [details]
Patch

Clearing flags on attachment: 53276

Committed r57572: <http://trac.webkit.org/changeset/57572>
Comment 6 WebKit Commit Bot 2010-04-14 02:01:12 PDT 
All reviewed patches have been landed.  Closing bug.