WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 37519
Teach webkit-patch how to handle revisions missing ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=37519
Summary
Teach webkit-patch how to handle revisions missing ChangeLogs
Eric Seidel (no email)
Reported
2010-04-13 13:57:04 PDT
Teach webkit-patch how to handle revisions missing ChangeLogs
Attachments
Patch
(5.73 KB, patch)
2010-04-13 14:00 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-04-13 14:00:17 PDT
Created
attachment 53276
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-04-13 14:01:34 PDT
This fixes the exception Adam Roben hit when trying to run failure-reason yesterday.
Adam Barth
Comment 3
2010-04-13 14:37:57 PDT
Comment on
attachment 53276
[details]
Patch good point.
Eric Seidel (no email)
Comment 4
2010-04-13 14:47:36 PDT
I don't really like this current handling, especially due to the copy/paste logging code. But I'm not sure CommitInfo even makes sense w/o ChangeLogs. :)
WebKit Commit Bot
Comment 5
2010-04-14 02:01:07 PDT
Comment on
attachment 53276
[details]
Patch Clearing flags on attachment: 53276 Committed
r57572
: <
http://trac.webkit.org/changeset/57572
>
WebKit Commit Bot
Comment 6
2010-04-14 02:01:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug